Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST: re-enable unit test for docstrings #247

Merged
merged 27 commits into from
Mar 3, 2021
Merged

TEST: re-enable unit test for docstrings #247

merged 27 commits into from
Mar 3, 2021

Conversation

j-ittner
Copy link
Member

No description provided.

@j-ittner j-ittner added bug Something isn't working build Related to the test & build pipeline labels Feb 19, 2021
@j-ittner j-ittner added this to the 1.0.2 milestone Feb 19, 2021
@j-ittner j-ittner self-assigned this Feb 19, 2021
@j-ittner j-ittner marked this pull request as draft February 19, 2021 16:44
@j-ittner j-ittner changed the base branch from develop to 1.1.x February 22, 2021 09:28
@j-ittner j-ittner modified the milestones: 1.0.2, 1.1.0 Feb 22, 2021
@j-ittner j-ittner added documentation Improvements or additions to documentation and removed bug Something isn't working labels Feb 22, 2021
@j-ittner j-ittner changed the title FIX: re-enable unit test for docstrings TEST: re-enable unit test for docstrings Feb 22, 2021
@j-ittner j-ittner changed the base branch from 1.1.x to dev/1.1.0rc0 February 24, 2021 15:51
@j-ittner j-ittner changed the base branch from dev/1.1.0rc0 to 1.1.x February 24, 2021 16:50
@j-ittner j-ittner changed the base branch from 1.1.x to develop February 25, 2021 16:07
@j-ittner
Update pyproject.toml
4d87d4e 
add support for 1.1.0 release candidates
@j-ittner j-ittner marked this pull request as ready for review February 25, 2021 16:09
@j-ittner j-ittner changed the base branch from develop to 1.1.x February 25, 2021 16:23
@j-ittner j-ittner requested a review from mgelsm March 1, 2021 13:51
joerg-schneider
joerg-schneider previously approved these changes Mar 2, 2021
View reviewed changes
@joerg-schneider
Copy link
Collaborator

joerg-schneider commented Mar 2, 2021 •
edited
Loading

@j-ittner
Here (= from 1.1.x development branch) we are checking out pytools + sklearndf from develop (=next patch version, 1.0.2), however they should have been checked out from 1.1.x in order for the build requirements to be met here (>1.1).

Is this something we should make dynamic in the pipeline? (e.g. a conditional check-out stage for the libraries)

Comment obsolete – discussed on Slack, for now, we'll set 1.1.x by hand in the pipeline. The current issue in building facet is inherited from sklearndf, has been resolved there and should disappear on next pipeline run given a new commit

@joerg-schneider

This comment has been minimized.

Sign in to view
@j-ittner j-ittner requested a review from joerg-schneider March 2, 2021 21:38
@j-ittner j-ittner merged commit 6b76ebc into 1.1.x Mar 3, 2021
@j-ittner j-ittner deleted the bugfix/test_docs branch March 3, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerg-schneider joerg-schneider joerg-schneider approved these changes

@mgelsm mgelsm Awaiting requested review from mgelsm

Assignees

@j-ittner j-ittner

Labels
build Related to the test & build pipeline documentation Improvements or additions to documentation
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@j-ittner @joerg-schneider