Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize revised calculation approach #255

Merged
merged 20 commits into from
Mar 23, 2021
Merged

Finalize revised calculation approach #255

merged 20 commits into from
Mar 23, 2021

Conversation

j-ittner
Copy link
Member

This PR will

  • calculate synergy before calculating redundancy, as was the case in the original calculation approach
  • no longer average SHAP values across splits, but instead base calculations on individual SHAP values

@j-ittner j-ittner added the API New feature or request label Mar 15, 2021
@j-ittner j-ittner added this to the 1.1.0 milestone Mar 15, 2021
@j-ittner j-ittner self-assigned this Mar 15, 2021
@j-ittner j-ittner marked this pull request as draft March 15, 2021 20:58
j-ittner and others added 12 commits March 15, 2021 22:43
@j-ittner
remove LearnerInspector parameter 'orthogonalize': fix to True
8e7afc9
@j-ittner
do not calculate SHAP legacy global explanations unless legacy=True
db3136f
@j-ittner
Merge branch '1.1.x' into feature/red_after_syn
7a41e7d
@j-ittner
Merge branch '1.1.x' into feature/red_after_syn
09e8307
@j-ittner
remove 'orthogonalize' option from shap explainers: always orthogonalize
84c1a90
@j-ittner
add a missing parameter to a docstring
2c7b3ac
@j-ittner
factor out SHAP context creation before global explanation calculations
ef59e00
@j-ittner
store affinity matrices as one ndarray, not as nested tuples
8f06fb8
@j-ittner
prep code for separate calculations per split, and mean/std aggregations
61c7488
@j-ittner
Prevent division by zero for relative symmetry of 0-importance features
b50305d
@j-ittner
Calculate S/R/A matrices separately per split, then get mean and std
7ec496d
@j-ittner
Add release notes for FACET 1.1.0
9bf7e36
@j-ittner j-ittner marked this pull request as ready for review March 19, 2021 14:31
@joerg-schneider joerg-schneider self-requested a review March 23, 2021 11:34
@j-ittner j-ittner merged commit f9c3092 into 1.1.x Mar 23, 2021
@j-ittner j-ittner deleted the feature/red_after_syn branch March 23, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerg-schneider joerg-schneider joerg-schneider approved these changes

@jason-bentley jason-bentley Awaiting requested review from jason-bentley

@konst-int-i konst-int-i Awaiting requested review from konst-int-i

@mgelsm mgelsm Awaiting requested review from mgelsm

@rkdy rkdy Awaiting requested review from rkdy

Assignees

@j-ittner j-ittner

Labels
API New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@j-ittner @joerg-schneider