Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: exclude RC releases of next minor release in requirements #279

Merged
merged 7 commits into from
Apr 7, 2021

Conversation

joerg-schneider
Copy link
Collaborator

The current setup on develop breaks the default build test, as for Conda, the gamma-pytools version specifier in place >=1.0.2,<1.1 still allows any 1.1-RC version, as pre-releases seem not to be not excluded by default, and they meet the constraint of being lower than 1.1.*.:

https://dev.azure.com/gamma-facet/facet/_build/results?buildId=3443&view=logs&j=09dd16d0-0872-5106-121a-048cc4d08c2a&t=4946b2ab-680e-5c2a-25a7-369fdd80cbcd&l=12371

@joerg-schneider joerg-schneider self-assigned this Mar 31, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
j-ittner
j-ittner previously approved these changes Mar 31, 2021
Copy link
Member

@j-ittner j-ittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@j-ittner
Copy link
Member

Need BCG-X-Official/pytools#222 to make this work, let's first merge that one then return to here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@joerg-schneider
Copy link
Collaborator Author

Need BCG-Gamma/pytools#222 to make this work, let's first merge that one then return to here.

Thanks! PR accepted

@j-ittner j-ittner changed the title BUILD: exclude RC releases of next minor release in requires BUILD: exclude RC releases of next minor release in requirements Apr 7, 2021
@j-ittner j-ittner added the build Related to the test & build pipeline label Apr 7, 2021
@j-ittner j-ittner added this to the 1.1.1 milestone Apr 7, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@j-ittner j-ittner self-requested a review April 7, 2021 15:13
j-ittner
j-ittner previously approved these changes Apr 7, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@j-ittner j-ittner self-requested a review April 7, 2021 17:39
@j-ittner j-ittner merged commit e9a925c into develop Apr 7, 2021
@j-ittner j-ittner deleted the build/prep-1.0.3 branch April 7, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to the test & build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants