Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: import catboost module if present, else create local module mockup #306

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

j-ittner
Copy link
Member

@j-ittner j-ittner commented Sep 24, 2021

This PR makes sure that catboost is properly defined in the local namespace of private module _explainer.py. No impact on the public API, but eliminates a warning during the Sphinx documentation build.

@j-ittner j-ittner added the bug Something isn't working label Sep 24, 2021
@j-ittner j-ittner added this to the 1.1.2 milestone Sep 24, 2021
@j-ittner j-ittner self-assigned this Sep 24, 2021
Copy link
Contributor

@bhadurishirsesh bhadurishirsesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood the change, want to understand the need for try except in the import step

@j-ittner
Copy link
Member Author

Understood the change, want to understand the need for try except in the import step

catboost is not a required module, so we use try: … except: … to gracefully handle the case that catboost is not available

@j-ittner j-ittner merged commit 5deea5e into 1.1.x Sep 24, 2021
@j-ittner j-ittner deleted the fix/catboost_conditional_import branch September 24, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants