Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: adopt revised design of pytools visualisations #312

Merged
merged 21 commits into from
Oct 19, 2021
Merged

API: adopt revised design of pytools visualisations #312

merged 21 commits into from
Oct 19, 2021

Conversation

j-ittner
Copy link
Member

@j-ittner j-ittner commented Oct 15, 2021 •
edited
Loading

This PR updates the facet package to work with the API changes for the redesigned and enhanced visualisations in pytools.viz.

@j-ittner
API: remove custom blank line at end of simulation output
c30791b
@j-ittner
API: return LearnerInspector matrix outputs as Matrix instances
8529981
@j-ittner
API: move class LinkageTree to module pytools.data
acbe4c3
@j-ittner
TEST: update unit tests for new Matrix class
11060f0
@j-ittner
API: annotate affinity matrices with weights and axis labels
46f1b2a
@j-ittner
API: feature/dependent feature --> primary feature/associated feature
5f7a6c0
@j-ittner
VIZ: set color of axis labels to foreground color
f67a339
@j-ittner
Merge branch '2.0.x' into api/drawer_style_redesign
b0392d0
@j-ittner
DOC: update release notes
c0880d3
@j-ittner
API: order feature linkage leaves for minimal neighbour distance
5cace36
@j-ittner
Merge branch '2.0.x' into api/drawer_style_redesign
fb855b8
@j-ittner
API: rename Matrix.data to .values, and .weight_label to .value_label
15a3a22
@j-ittner
TEST: support NAN values in print_expected_matrix() helper function
cf35f89
@j-ittner
API: set diagonals of affinity matrices to np.nan
3b23ab4
@j-ittner
API: return Matrix instances from feature_interaction_matrix()
06f87bd
@j-ittner
REFACTOR: rename __feature_matrix_to_df to __arrays_to_matrix
bebad34
@j-ittner
REFACTOR: import scipy modules instead of individual functions
c8f0488
@j-ittner
DOC: update release notes
4e04a9e
@j-ittner
DOC: correct typos and glitches in release notes
df7d7c7
@j-ittner
DOC: tweak release notes
3848483
@j-ittner
Merge branch '2.0.x' into api/drawer_style_redesign
8af3d52
@j-ittner j-ittner self-assigned this Oct 15, 2021
@j-ittner j-ittner added API New feature or request refactor Internal changes that don't change functionality and removed API New feature or request labels Oct 15, 2021
@j-ittner j-ittner added this to the 2.0.0 milestone Oct 15, 2021
This was referenced Oct 19, 2021
Merged
Merged
@j-ittner j-ittner merged commit d700cfd into 2.0.x Oct 19, 2021
@j-ittner j-ittner deleted the api/drawer_style_redesign branch October 19, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgelsm mgelsm mgelsm approved these changes

@joerg-schneider joerg-schneider Awaiting requested review from joerg-schneider

@bhadurishirsesh bhadurishirsesh Awaiting requested review from bhadurishirsesh

Assignees

@j-ittner j-ittner

Labels
API New feature or request refactor Internal changes that don't change functionality
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@j-ittner @mgelsm