Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: remove previous LearnerRanker #318

Merged
merged 5 commits into from
Jan 24, 2022
Merged

API: remove previous LearnerRanker #318

merged 5 commits into from
Jan 24, 2022

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Jan 21, 2022

Removes previous LearnerRanker and adjust unit tests.

@mtsokol mtsokol marked this pull request as ready for review January 21, 2022 14:13
@mtsokol mtsokol requested a review from j-ittner January 21, 2022 14:13
@mtsokol mtsokol self-assigned this Jan 21, 2022
j-ittner
j-ittner approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@j-ittner j-ittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@mtsokol mtsokol merged commit a68b3a4 into api/no_xfit_learner_ranker Jan 24, 2022
@mtsokol mtsokol deleted the api/no_xfit_learner_ranker_tests branch January 24, 2022 15:58
@mtsokol mtsokol mentioned this pull request Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-ittner j-ittner j-ittner approved these changes

Assignees

@mtsokol mtsokol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsokol @j-ittner