Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: add support for pandas 1.4 for 2.0.x #319

Merged
merged 6 commits into from
Jan 28, 2022
Merged

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Jan 24, 2022

Due to the fact that on 22.01.2022 a new pandas version was released (1.4.0) current pandas dependency constraint is invalid as pandas ~= 1.3 allows to upgrade to 1.4 which is incompatible.
(source: https://stackoverflow.com/a/67374648/6717327)

It can be fixed by changing option name that was modified in the new version.

@mtsokol mtsokol requested a review from j-ittner January 24, 2022 15:48
@mtsokol
Copy link
Contributor Author

mtsokol commented Jan 24, 2022

Should be also updated downstream in 1.2.x and 1.1.x.

@mtsokol mtsokol self-assigned this Jan 24, 2022
@mtsokol mtsokol force-pushed the fix/extend_pandas_version branch from 31e940d to 4c08cc0 Compare January 24, 2022 16:11
@j-ittner j-ittner changed the title FIX: extend pandas version dependency FIX: add support for pandas 1.4 Jan 24, 2022
@mtsokol mtsokol changed the title FIX: add support for pandas 1.4 FIX: add support for pandas 1.4 for 2.0.x Jan 28, 2022
Copy link
Member

@j-ittner j-ittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@j-ittner j-ittner merged commit 43895df into 2.0.x Jan 28, 2022
@j-ittner j-ittner deleted the fix/extend_pandas_version branch January 28, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants