Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: make method FittableMixin.ensure_fitted public #330

Merged
merged 2 commits into from
Mar 4, 2022
Merged

API: make method FittableMixin.ensure_fitted public #330

merged 2 commits into from
Mar 4, 2022

Conversation

j-ittner
Copy link
Member

@j-ittner j-ittner commented Mar 4, 2022

No description provided.

@j-ittner j-ittner added the API New feature or request label Mar 4, 2022
@j-ittner j-ittner added this to the 2.0.0 milestone Mar 4, 2022
@j-ittner j-ittner requested a review from joerg-schneider March 4, 2022 17:04
@j-ittner j-ittner self-assigned this Mar 4, 2022
mtsokol
mtsokol suggested changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@mtsokol mtsokol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @j-ittner, shouldn't we also introduce same changes in src/sklearndf/_sklearndf.py in EstimatorDF in line 117?

self._ensure_fitted()

EstimatorDF also derives FittableMixin. If yes then I think same change is required in lines 314 and 329 in TransformerDF.

@j-ittner
Copy link
Member Author

j-ittner commented Mar 4, 2022

Hi @j-ittner, shouldn't we also introduce same changes in src/sklearndf/_sklearndf.py in EstimatorDF in line 117?

self._ensure_fitted()

EstimatorDF also derives FittableMixin. If yes then I think same change is required in lines 314 and 329 in TransformerDF.

EstimatorDF no longer implements FittableMixin in its latest implementation. FittableMixin expects exactly one positional argument, EstimatorDF needs two (X and y). So the only solution I saw was to break the link.

@mtsokol
Copy link
Contributor

mtsokol commented Mar 4, 2022

Ah, sorry - I jumped to sklearndf while checking and didn't checked out latest version there. Now all clear to to me!

@j-ittner j-ittner merged commit 1a7859b into 2.0.x Mar 4, 2022
@j-ittner j-ittner deleted the api/ensure_fitted_public branch March 4, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsokol mtsokol mtsokol approved these changes

@joerg-schneider joerg-schneider Awaiting requested review from joerg-schneider

Assignees

@j-ittner j-ittner

Labels
API New feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@j-ittner @mtsokol