REFACTOR: linting for 2.0 release #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting_for_2.0_release # Conflicts: # test/test/conftest.py # test/test/facet/test_inspection.py
j-ittner
added a commit
that referenced
this pull request
Sep 13, 2022
* API: remove custom blank line at end of simulation output * API: return LearnerInspector matrix outputs as Matrix instances * API: move class LinkageTree to module pytools.data * TEST: update unit tests for new Matrix class * API: annotate affinity matrices with weights and axis labels * API: feature/dependent feature --> primary feature/associated feature * VIZ: set color of axis labels to foreground color * DOC: update release notes * API: order feature linkage leaves for minimal neighbour distance * API: rename Matrix.data to .values, and .weight_label to .value_label * TEST: support NAN values in print_expected_matrix() helper function * API: set diagonals of affinity matrices to np.nan * API: return Matrix instances from feature_interaction_matrix() * REFACTOR: rename __feature_matrix_to_df to __arrays_to_matrix * REFACTOR: import scipy modules instead of individual functions * DOC: update release notes * DOC: correct typos and glitches in release notes * DOC: tweak release notes * API: run LearnerInspector on full sample instead of crossfit splits * REFACTOR: simplify signature of ShapCalculator._calculate_shap() * REFACTOR: use sklearn.base.is_classifier to check for classifier * FIX: return type of make_explainer is BaseExplainer * REFACTOR: use triple quotes for arg match of @inheritdoc * REFACTOR: eliminate inner function make_explainer * API: make explainer factory arguments keyword-only * API: rename TreeExplainerFactory arg use_background_dataset to uses_… * API: base class ExplainerFactory on HasExpressionRepr * API: state explainer when warning about ignoring shap_interaction=True * API: introduce class ParallelExplainer * API: make arg max_job_size required in ExplainerQueue * REFACTOR: simplify access of BaseExplainer.shap_interaction_values() * REFACTOR: push binary classif. handling down to ClassifierShapCalculator * API: run simulations on full sample instead of crossfit splits * API: simplify UnivariateSimulationResult API; simplify simulator classes * API: simulate partitions in parallel * DOC: update simulation docstrings * FIX: remove references to removed attribute LearnerInspector.crossfit * FIX: remove obsolete arg `aggregation` from feature_…_matrix methods * DOC: remove references to crossfit from LearnerInspector documentation * TEST: remove LearnerCrossfit from learner inspector unit tests * TEST: remove obsolete helper functions * TEST: replace iris_classifier_model_binary by iris_classifier_binary * TEST: remove obsolete fixture iris_classifier_crossfit_binary * TEST: use strings not pandas indices to select ColumnTransformer columns * API: implement class ParameterSpace and related classes * add initial version of CrossFit-free LearnerRanker * API: provide all univariate simulation results as a data frame * API: refer to simulation results as mean simulated outputs, not median * DEV: get shap module from conda instead of pypi to avoid numpy conflict * FIX: Set return signature of ShapProjector._calculate to None * FIX: replace iris_classifier_model_binary with iris_classifier_binary * API: remove previous LearnerRanker * API: enable tests for new LearnerRanker * REFACTOR: remove obsolete function _learner_type() * REFACTOR: rename LearnerRanker2 to LearnerRanker * REFACTOR: remove classes LearnerGrid and LearnerEvaluation * API: set default candidate to None * API: add unlift method to ParameterSpace * API: introduce CandidateEstimatorDF * API: rename candidate to raw_estimator * API: add scoring preprocessing * DOC: rewrite Classification_with_Facet tutorial * DOC: rewrite Water_Drilling_Incident_Classification_with_Facet * DOC: adjust next three notebooks * DOC: update rst files * DOC: update all tutorials * DOC: add minor change * DOC: add new contributors * DOC: complete team page * DOC: replace quoted type hints with forward references * DOC: tweak docstrings and comments * BUILD: require pytools 2dev7 for build and test * BUILD: update min/max requirements in pyproject.toml * BUILD: update min/max requirements in pyproject.toml * DOC: reran notebooks with latest dependencies * DOC: add duplicate class variable declarations in subclasses for Sphinx * REFACTOR: linting for 2.0 release (#341) * API: move simulation base classes to new module facet.simulation.base * REFACTOR: remove an obsolete 'if' clause * REFACTOR: declare constant for repetitive string literal * FIX: change a type hint from List to Sequence * DOC: remove an obsolete comment * REFACTOR: declare constants for repetitive string literals * REFACTOR: clarified comments and variable names * REFACTOR: de-complexify Sample.__init__ * REFACTOR: remove an unused variable * REFACTOR: disambiguate a regular expression * REFACTOR: merge a nested 'if' expression * REFACTOR: improve comments * REFACTOR: simplify CSS * REFACTOR: un-bracket alternatives in regular expression * TEST: remove unused fixtures from test method arguments * TEST: remove an obsolete to-do * TEST: anonymize unused loop variables * TEST: add constants for recurring exception messages * TEST: minor code tweaks * DOC: tweak the getting-started example notebook * DOC: add summary to 2.0 release notes * DOC: tweak release notes * DOC: tweak docstrings * DOCS: Rerun tutorial notebooks with sklearndf 2.0.1 * REFACTOR: move class LearnerInspector to new _learner_inspector.py * DOC: tweak docstrings Co-authored-by: Jan Ittner <github.com@ittner.eu> Co-authored-by: Jan Ittner <ittner.jan@bcg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.