REFACTOR: remove duplicated shap_calculator method #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for spotting this, indeed I forgot to remove the method in the child class after pulling it up to the base class. |
j-ittner
added a commit
that referenced
this pull request
Jul 10, 2023
…ner pipelines (#369) * API: preserve row order in ShapCalculator output * TEST: suppress numba debug messages * API: add class NativeLearnerInspector for native scikit-learn learners * REFACTOR: pull learner inspector initializer up to base class * REFACTOR: remove obsolete LearnerInspector.shap_calculator() * REFACTOR: remove duplicated shap_calculator method (#370) --------- Co-authored-by: Mateusz Sokół <8431159+mtsokol@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @j-ittner,
Here I share my review for for #369: For me the PR is ready for merging, the only comment I have is that
shap_calculatormethod implementation seems to be repeated inLearnerInspector.I would rely only on
_BaseLearnerInspectorimplementation ofshap_calculatorand reuse it inLearnerInspectorandNativeLearnerInspector.The Implementation that I drop here differs only in line 330 and 316, where it can be done the same way as in
_BaseLearnerInspector.What do you think?