Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/regression notebooks #38

Merged
merged 19 commits into from
Sep 8, 2020
Merged

Conversation

konst-int-i
Copy link
Contributor

@konst-int-i konst-int-i commented Aug 28, 2020

This PR

  • Adds regression example notebook for the documentation and updates examples.rst accordingly

Run instructions:

  • Make sure your facet-develop env is up to date
  • Run make html from within the sphinx folder
  • You should see the Regression notebook showing up in the "Examples" section

Copy link
Contributor

@jason-bentley jason-bentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Executed as instructed and yielded expected addition of regression worked examples in the FACET documentation, see below:
image
image

Also looked good on navigating through each section for the Predictive Maintenance Regression example.
image

Note if a future PR, the Regression machine failures on a water well notebook needs to be updated and added to the examples.rst file as follows:

Regression machine failures on a water well (simulated)
-----------------------------------------------------------
.. toctree::
   :maxdepth: 2

   tutorial/Regression_Water_Drilling_Simulation_Example

@jason-bentley jason-bentley merged commit 6325a4b into develop Sep 8, 2020
@j-ittner j-ittner deleted the feature/regression_notebooks branch September 11, 2020 09:39
@j-ittner j-ittner added this to the 1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants