Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various bugs related to univariate probability simulations #47

Merged
merged 6 commits into from
Sep 8, 2020
Merged

Fix various bugs related to univariate probability simulations #47

merged 6 commits into from
Sep 8, 2020

Conversation

j-ittner
Copy link
Member

@j-ittner j-ittner commented Sep 8, 2020 •
edited
Loading

  • skip nan values when calculating partitioning
  • fix calculation of baseline value
  • improve rendering of matplot simulation plots (rounded floats, legend, clearer y axis)

Fixes #46

@j-ittner j-ittner self-assigned this Sep 8, 2020
jason-bentley
jason-bentley approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@jason-bentley jason-bentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and address the bugs indicated. Re-run of notebook yielded expected output without any errors as shown below:
image

image

@jason-bentley jason-bentley merged commit 5411283 into develop Sep 8, 2020
@j-ittner j-ittner deleted the bugfix/probability_simulation branch September 8, 2020 12:58
@j-ittner j-ittner added this to the 1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-bentley jason-bentley jason-bentley approved these changes

Assignees

@j-ittner j-ittner

Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.

Issues with UnivariateProbabilitySimulator and missing values/scale y
2 participants
@j-ittner @jason-bentley