Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/latex rendering #48

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Bugfix/latex rendering #48

merged 2 commits into from
Sep 9, 2020

Conversation

rkdy
Copy link
Collaborator

@rkdy rkdy commented Sep 8, 2020

This PR

  • Fixes a LaTeX error in the docstring:
    image
  • Adds LaTeX requirements and external links for more info to development guidelines

Run instructions:

  • Make sure your facet-develop env is up to date

  • Run make html from within the sphinx folder

  • Check that the matrix in the docstring of feature_interaction_matrix is rendered correctly:

    facet/sphinx/build/html/api/facet.inspection.html#facet.inspection.LearnerInspector.feature_interaction_matrix

@rkdy rkdy added the bug Something isn't working label Sep 8, 2020
@j-ittner
Copy link
Member

j-ittner commented Sep 8, 2020

Looks good, thanks Ricardo for addressing this!

Copy link
Contributor

@jason-bentley jason-bentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@jason-bentley jason-bentley merged commit f5e74e8 into develop Sep 9, 2020
@j-ittner j-ittner deleted the bugfix/latex_rendering branch September 11, 2020 09:39
@j-ittner j-ittner added this to the 1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants