Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update API for Sample.keep() and Sample.drop() #59

Merged
merged 2 commits into from
Sep 11, 2020
Merged

update API for Sample.keep() and Sample.drop() #59

merged 2 commits into from
Sep 11, 2020
+14 −6

Conversation

j-ittner
Copy link
Member

  • accept single strings for arg features
  • raise ValueError when features passed to Sample.drop() are unknown

@j-ittner j-ittner self-assigned this Sep 11, 2020
@j-ittner j-ittner added the API New feature or request label Sep 11, 2020
jason-bentley
jason-bentley approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@jason-bentley jason-bentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes to code - looks good. Thanks!

@j-ittner j-ittner merged commit 73dd445 into develop Sep 11, 2020
@j-ittner j-ittner deleted the feature/sample_keep_drop branch September 11, 2020 15:45
@j-ittner j-ittner added this to the 1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-bentley jason-bentley

Assignees

@j-ittner j-ittner

Labels
API New feature or request
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j-ittner @jason-bentley