Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename remaining references to properties features_in_ and features_out_ #72

Merged
merged 1 commit into from
Sep 23, 2020
Merged

rename remaining references to properties features_in_ and features_out_ #72

merged 1 commit into from
Sep 23, 2020

Conversation

j-ittner
Copy link
Member

… also fix handling of borata output in some cases:

Features to be dropped should be determined as boruta_pipeline.features_original_.unique(), not boruta_pipeline.features_out_

@j-ittner j-ittner self-assigned this Sep 23, 2020
jason-bentley
jason-bentley approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@jason-bentley jason-bentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Thank you.

@jason-bentley jason-bentley merged commit f43fb9f into develop Sep 23, 2020
@j-ittner j-ittner deleted the bugfix/use_renamed_featture_xyz_properties branch September 23, 2020 16:42
@j-ittner j-ittner added this to the 1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-bentley jason-bentley jason-bentley approved these changes

Assignees

@j-ittner j-ittner

Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@j-ittner @jason-bentley