Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor variable names #73

Merged
merged 2 commits into from
Sep 25, 2020
Merged

refactor variable names #73

merged 2 commits into from
Sep 25, 2020

Conversation

mgelsm
Copy link
Contributor

@mgelsm mgelsm commented Sep 23, 2020 •
edited
Loading

Change variable names to more contextual entities.

Main changes:

  • sample -> drilling_obs
  • inspector -> model_inspector
  • cont_partitioner -> rop_bins
  • simulator -> rop_simulator
  • simulation -> rop_simulation

@mgelsm mgelsm added the API New feature or request label Sep 23, 2020
@mgelsm mgelsm self-assigned this Sep 23, 2020
jason-bentley
jason-bentley approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@jason-bentley jason-bentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, nice changes for improved clarity and the increased bootstrap. Thanks!

@jason-bentley jason-bentley merged commit 5489ecb into develop Sep 25, 2020
@j-ittner j-ittner deleted the docs/rename_drilling_example_vars branch September 30, 2020 20:35
@j-ittner j-ittner added this to the 1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-bentley jason-bentley jason-bentley approved these changes

@j-ittner j-ittner Awaiting requested review from j-ittner

Assignees

@mgelsm mgelsm

Labels
API New feature or request
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mgelsm @jason-bentley @j-ittner