Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update conditional build logic depending on target branch and scheduling #78

Merged
merged 14 commits into from
Sep 30, 2020
Merged

update conditional build logic depending on target branch and scheduling #78

merged 14 commits into from
Sep 30, 2020

Conversation

j-ittner
Copy link
Member

@j-ittner j-ittner commented Sep 29, 2020 •
edited
Loading

This changes the Azure pipeline to check whether the PR changes the conda build configuration.

Then different tests are carried out depending on context:

  • if the PR merges to master or a release branch, build 3 conda packages (min, max, unconstrained versions) and run pytest on each
  • if the PR merges to develop or any other branch, and if the PR changes the conda build configuration, build 1 conda package (max versions) and run pytest on the package
  • otherwise, do not build a conda package, instead create the development conda environment and run pytest in that environment

@j-ittner j-ittner requested a review from rkdy September 29, 2020 16:18
@j-ittner j-ittner self-assigned this Sep 29, 2020
rkdy
rkdy previously approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@rkdy rkdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

rkdy
rkdy approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@rkdy rkdy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some warnings during testing, but I suggest we address these in a separate PR (opened issue for now: #81) and get this PR merged.

image

@j-ittner j-ittner merged commit 8ecb02a into develop Sep 30, 2020
@j-ittner j-ittner deleted the feature/conda_build_pytest branch September 30, 2020 20:35
@j-ittner j-ittner added this to the 1.0.1 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkdy rkdy rkdy approved these changes

Assignees

@j-ittner j-ittner

Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@j-ittner @rkdy