Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove credentials from ADAM pipeline #116

Merged
merged 3 commits into from
Feb 25, 2016

Conversation

fnothaft
Copy link
Contributor

Resolves #107. First two commits are validated. I ran into an error during VQSR, which I believe c9abdf2 should fix, so I'm validating that now. Should have results by morning.

@hannes-ucsc
Copy link
Contributor

Remove needs work when validation is done.

…otype prior to VQSR, and will recalculate some missing annotations.
@fnothaft
Copy link
Contributor Author

Remove needs work when validation is done.

So I've validated the credential removal part, but I'm running into a new fascinating bug (w00t!) that I haven't been able to root cause yet. Essentially, the BAM written out from ADAM and uploaded to S3 is corrupt. I'm modifying the scripts right now so that I can keep HDFS up after the ADAM pipeline completes so that I can root cause whether the issue is in ADAM's output or in the upload to S3. I'll report back as I know more.

@fnothaft
Copy link
Contributor Author

Actually, @hannes-ucsc, this is good to go WRT #107. I'll remove the needs work tag and open a new issue/PR for the new bug I'm working through.

hannes-ucsc added a commit that referenced this pull request Feb 25, 2016
Remove credentials from ADAM pipeline
@hannes-ucsc hannes-ucsc merged commit ea17b0e into BD2KGenomics:master Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all AWS credential-passing code from ADAM scripts
3 participants