Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve modal performances and fix sizing issues #284

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

Cl0v1s
Copy link
Collaborator

@Cl0v1s Cl0v1s commented Mar 23, 2024

No description provided.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<li className='dropdown-menu__separator' />

<li>
<button type='button' onClick={onClose}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

@Cl0v1s Cl0v1s merged commit de3f44c into peaceful-panther Mar 23, 2024
1 check passed
Cl0v1s added a commit that referenced this pull request Mar 23, 2024
* fix: various translation issues

* feat: improve bulgarian translation (#266)

* chore: add new mangane logo and use it in readme

* fix: can not 'block notifications from strangers' (#277)

* fix: dedup posts in timeline (#278)

* fix: add custom reactions (#280)

* feat: add loader and explanation to directory view (#281)

* fix: filter outdated scheduled posts on the frontend (#282)

* feat: add scheduled post deletion (#283)

* fix: unable to change email (#276)

* fix: improve modal performances and fix sizing issues (#284)

* chore: update translations

---------

Co-authored-by: vinzv <vinz@vinzv.de>
Co-authored-by: Salif Mehmed <mail@salif.eu>
Co-authored-by: Clovis <clovis@synapse-medicine.com>
Cl0v1s added a commit that referenced this pull request Mar 25, 2024
* fix: various translation issues

* feat: improve bulgarian translation (#266)

* chore: add new mangane logo and use it in readme

* fix: can not 'block notifications from strangers' (#277)

* fix: dedup posts in timeline (#278)

* fix: add custom reactions (#280)

* feat: add loader and explanation to directory view (#281)

* fix: filter outdated scheduled posts on the frontend (#282)

* feat: add scheduled post deletion (#283)

* fix: unable to change email (#276)

* fix: improve modal performances and fix sizing issues (#284)

* chore: update translations

* feat: new UI with no top navbar, reworked hashtag screen, reworked bottom nav on mobile (#286)

---------

Co-authored-by: vinzv <vinz@vinzv.de>
Co-authored-by: Salif Mehmed <mail@salif.eu>
Co-authored-by: Clovis <clovis@bdx.town>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant