-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes merge issues? #134
Fixes merge issues? #134
Conversation
Trying to fix this all now. |
@BDisp Please carefully check that I didn't undo any of your fixes that matter. I think this finally brings all of this together. |
@tig this is equal to mine after merge and really some of fixes was undo. I already fix all merge errors. I can run it but some unit tests are failing. I'll push my changes to my PR to you also check, please. |
It's not completely equal because all unit test pass. However, in gui-cs#2385, unit tests are failing. |
Note, I was very careful to do each change as a separate commit, so hopefully that will help figure out what I actually fixed vs. just duplicated. |
I think.