Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes merge issues? #134

Merged

Conversation

tig
Copy link

@tig tig commented Mar 3, 2023

I think.

@tig
Copy link
Author

tig commented Mar 3, 2023

Trying to fix this all now.

@tig
Copy link
Author

tig commented Mar 3, 2023

@BDisp Please carefully check that I didn't undo any of your fixes that matter. I think this finally brings all of this together.

@BDisp
Copy link
Owner

BDisp commented Mar 3, 2023

@tig this is equal to mine after merge and really some of fixes was undo. I already fix all merge errors. I can run it but some unit tests are failing. I'll push my changes to my PR to you also check, please.

@tig
Copy link
Author

tig commented Mar 3, 2023

@tig this is equal to mine after merge and really some of fixes was undo. I already fix all merge errors. I can run it but some unit tests are failing. I'll push my changes to my PR to you also check, please.

It's not completely equal because all unit test pass. However, in gui-cs#2385, unit tests are failing.

@tig
Copy link
Author

tig commented Mar 3, 2023

Note, I was very careful to do each change as a separate commit, so hopefully that will help figure out what I actually fixed vs. just duplicated.

@BDisp BDisp merged commit ef9124c into BDisp:v2_layout-improvements Mar 5, 2023
@tig tig deleted the BDisp-v2_layout-improvements branch April 3, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants