Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a few features and fix #134

Merged
merged 8 commits into from
May 3, 2021
Merged

Adding a few features and fix #134

merged 8 commits into from
May 3, 2021

Conversation

BDonnot
Copy link
Owner

@BDonnot BDonnot commented May 3, 2021

  • [BREAKING]: allow the opponent to chose the duration of its attack. This breaks the previous "Opponent.attack(...)"
    signature by adding an object in the return value. All code provided with grid2op are compatible with this
    new change. (for previously coded opponent, the only thing you have to do to make it compliant with
    the new interface is, in the opponent.attack(...) function return whatever_you_returned_before, None instead
    of simply whatever_you_returned_before
  • [FIXED]: an issue with the IncreasingFlatReward reward types
  • [ADDED]: a reward EpisodeDurationReward that is always 0 unless at the end of an episode where it returns a float
    proportional to the number of step made from the beginning of the environment.
  • [ADDED]: in the Observation the possibility to retrieve the current number of steps

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BDonnot BDonnot merged commit f9ed970 into master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant