Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naive maps updates #71

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Conversation

petiay
Copy link
Member

@petiay petiay commented May 27, 2023

Added several options:

  • Can now calculate the median of the BEAST results (instead of by default just the mean)
  • Can make maps of three stellar parameters - for now they are log(T), log(age), and initial Mass. Easy to tweak or add more.
  • Can input a chi2min threshold to cut BEAST stats before making maps
  • Updated map file naming (from experience it's nice to know the map resolution at a glance esp. when there are comparisons with various ISM maps).

Copy link
Member

@karllark karllark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Have a couple of comments that should be addressed.

megabeast/tools/make_naive_maps.py Outdated Show resolved Hide resolved
megabeast/tools/make_naive_maps.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 14.75%. Comparing base (8d43cf9) to head (0b512d8).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
megabeast/tools/make_naive_maps.py 5.88% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   15.21%   14.75%   -0.46%     
==========================================
  Files           6        6              
  Lines         355      366      +11     
==========================================
  Hits           54       54              
- Misses        301      312      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@karllark karllark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@karllark
Copy link
Member

No tests to speak of for megabeast yet. So ignoring these for now.

@karllark karllark merged commit 72292d7 into BEAST-Fitting:master Jul 30, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants