Box up all Packet variants.

Previously, the Packet enum was a whopping 4,264 bytes in size (over a page!). Not only is this just bad for performance (lots of memmoving), but I think it was also causing weird stack overflow segfaults on my machine.
BGR360 · Jan 18, 2022 · a79d5d8 · a79d5d8
1 parent 9fca022
commit a79d5d8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/protocol/src/protocol/mod.rs b/protocol/src/protocol/mod.rs
@@ -84,7 +84,7 @@ macro_rules! state_packets {
         $(
             $(
                 $(
-        $name($state::$dir::$name),
+        $name(Box<$state::$dir::$name>),
                 )*
             )+
         )+
@@ -184,7 +184,7 @@ macro_rules! state_packets {
                                                     packet.$field = Serializable::read_from(&mut buf)?;
                                                 }
                                             )+
-                                            Result::Ok(Option::Some(Packet::$name(packet)))
+                                            Result::Ok(Option::Some(Packet::$name(Box::new(packet))))
                                         },
                                     )*
                                         _ => Result::Ok(Option::None)

diff --git a/src/server/mod.rs b/src/server/mod.rs
@@ -98,7 +98,7 @@ macro_rules! handle_packet {
     }) => (
         match $pck {
         $(
-            protocol::packet::Packet::$packet(val) => $s.$func(val),
+            protocol::packet::Packet::$packet(val) => $s.$func(*val),
         )*
             _ => {},
         }