Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Adapter: refactoring-remove the replaceAll paramer from the Create() method inputs #114

Closed
alelom opened this issue Jul 4, 2019 · 1 comment · Fixed by #151
Closed
Assignees
Labels
type:compliance Non-conforming to code guidelines

Comments

@alelom
Copy link
Member

alelom commented Jul 4, 2019

As explained here #106

The replaceAll paramer in the Create() method exists only as a workaround for the File_Adapter.

I think that the Create method, in its suggested implementation should always stick to what it's supposed to do, that is creating.

Overriding = [Deleting the content and then creating] should be dealt with a call to Delete and then Create.

If someone wants the Create method to have an option to override, there is always the possibility of using the config.

Important note

This change will affect ALL TOOLKITS.

Regarding the File_Adapter, the change is done in the same PR that fixes this: #145

@alelom
Copy link
Member Author

alelom commented Nov 5, 2019

Closed by #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
1 participant