BHoM_Adapter: refactoring-refactor the ReplaceInMemory

[alelom]

The ReplaceInMemory has an counterintuitive structure that needs to be refactored.

Issue 1 - Fix missed VennDiagram bug

Fix #88.

Issue 2 - structure of ReplaceInMemory and call to Create()

Counter-intuitively, the Create method will have to take care not only to create (export) these objects, but it is assumed also to be deleting any object existing in the model.
To distinguish this case, there is a boolean argument replaceAll to be set to true when calling Create(), which is not good.

Step by step explanation:

1. The Method assumes that the Create method will delete all the existing objects from the model.
2. In order to do 1., an additional Boolean replaceAll was added to the Create method. When activated, it is assumed that the Create will be deleting objects. This parameter is used exclusively for this purpose.
3. Since 2. is always required when doing ReplaceInMemory, its call in the main Replace method hard-codes replaceAll to true (here renamed to overwriteObjects):

   BHoM_Adapter/BHoM_Adapter/CRUD/Replace.cs

   Lines 67 to 71 in 49d63e8

   	if (Config.ProcessInMemory)
   	{
   	objectsToCreate = ReplaceInMemory(newObjects, existing, tag);
   	overwriteObjects = true;
   	}

   
   So Create will get called with ReplaceAll set to true when ReplaceInMemory was used:
   

   BHoM_Adapter/BHoM_Adapter/CRUD/Replace.cs

   Line 84 in 49d63e8

   if (!Create(objectsToCreate, overwriteObjects))

   
   Which is definitely not nice.

I have raised an issue to collection all related toolkit issues: #114

Proposed solution

The replaceAll parameter should be removed by the Create method signature.
Any deletion should be preformed using the Delete method.

Issue 3 - usage of ReplaceInMemory

ReplaceInMemory involves the use of two AdapterConfig properties:

• ProcessInMemory needs to be true in order for ReplaceInMemory to be called.
• MergeWithComparer to have the ReplaceInMemory using the comparers to do the merge. If this is set to false, the ReplaceInMemory becomes a sort of "CreateOnly" method (except it does not Create the objects with the same tag currently Pushed, a rather cryptic behaviour).

Now, consider that in order to use ReplaceInMemory as intended, you need to:

• set ProcessInMemory to true, AND
• implement the Create() method as per point 1.

Let's find out about the usage of the ReplaceInMemory then:

➡️ The FileAdapter is the only one that uses ReplaceInMemory as intended.

Another 4 adapters are specifying ProcessInMemory as true, but since they are not implementing Create(), they are not using this ReplaceInMemory as intended. These are:
Unreal_Toolkit; Filing_Toolkit; Civil_Toolkit; GitHub_Toolkit.

➡️ For those, the theory is that people have been using ReplaceInMemory as a sort of CreateOnly method, disregarding tags.

➡️ AdapterConfig.MergeWithComparer is never used.

Proposed solution

• Delete AdapterConfig.MergeWithComparer. ReplaceInMemory should always use comparers, like ReplaceThroughAPI.
• Modify Unreal_Toolkit, Filing_Toolkit, Civil_Toolkit, GitHub_Toolkit to use a CreateOnly method instead of ReplaceInMemory.
• Modify the File_Adapter. For him, the Create() parameter replaceAll is always set to false. Some of the code needs to be cleaned.

[alelom]

Closed by #151