BHoM_Adapter: replaceInMemory does not make use of Venn intersection

[alelom]

Issue description

The ReplaceInMemory method performs the Venn diagram intersection, applies the MapSpecialProperties() method to it, then discards it:

BHoM_Adapter/BHoM_Adapter/CRUD/Replace.cs

Lines 144 to 149 in 12304b8

	if (Config.MergeWithComparer)
	{
	VennDiagram<T> diagram = Engine.DataStructure.Create.VennDiagram(newObjects, multiTaggedObjects.Concat(nonTaggedObjects), Comparer<T>());
	diagram.Intersection.ForEach(x => x.Item1.MapSpecialProperties(x.Item2, AdapterId));
	newObjects = diagram.OnlySet1;
	}

Proposed change

IEnumerable<T> objectsToCreate = null;

// Merge objects if required
if (Config.MergeWithComparer)
{
	VennDiagram<T> diagram = Engine.DataStructure.Create.VennDiagram(objectsToPush, multiTaggedObjects.Concat(nonTaggedObjects), Comparer<T>());
	diagram.Intersection.ForEach(x => x.Item1.MapSpecialProperties(x.Item2, AdapterId));

	objectsToCreate = diagram.OnlySet1.Concat(diagram.OnlySet2).Concat(diagram.Intersection.Select(x => x.Item1));
} else
	objectsToCreate = multiTaggedObjects.Concat(nonTaggedObjects).Concat(objectsToPush);

[alelom]

Now included in #106.

[alelom]

Realised with @adecler, using this table:

that we can remove the replaceInMemory, because all it actually does is to "delete a tag from the multitagged object, and delete object that only have that tag". Being it only used in the FileAdapter, we can:

• remove the method
• find appropriate solution for the fileAdapter
• only have 1 "Replace" method instead of "ReplaceThroughAPI" and "ReplaceInMemory"

[alelom]

Issue no longer relevant after Adapter refactoring.