You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "Public Adapter Method" Delete is the method called by the UI Delete component.
It should be renamed to "Remove" or something else that clarifies that it is not a CRUD method per se to avoid confusion.
The confusion is amplified by its default implementation, that only returns a call to the actual CRUD delete:
A rename would be beneficial for the following reasons:
It would be consistent with our philosophy of not exposing CRUD methods directly in the UI, unlike now (especially in light of the fact that I deleted the UpdateProperty component for the same reason, which is a good consistency improvement IMHO).
The fact that its default implementation only returns a call to the CRUD delete is only a side-effect of being a default implementation. You can always override the Delete component without affecting the CRUD Delete.
The public method should in principle be called something different than the CRUD Delete because it has all rights to implement additional functionality other than the CRUD Delete strictly speaking
While reviewing the BHoM_Adapter refactoring level03, I realised how confusing is to understand when an Adapter is overriding the actual CRUD Delete or when it's overriding the Delete component method
If we all agree, I will action this in the Level04 refactoring, where other script-breaking changes will happen.
While I was not too keen when reading the title, you're making a few good points. As far as I am concerned, it is even more important to make sure that the BHoM is clear and intuitive for the end user than for the few people creating the adapters. As long as "Remove" is well understood and accepted on the end user side, I fine with this idea.
The "Public Adapter Method" Delete is the method called by the UI Delete component.
It should be renamed to "Remove" or something else that clarifies that it is not a CRUD method per se to avoid confusion.
The confusion is amplified by its default implementation, that only returns a call to the actual CRUD delete:
BHoM_Adapter/BHoM_Adapter/BHoMAdapter.cs
Lines 172 to 175 in 9d3ea21
A rename would be beneficial for the following reasons:
If we all agree, I will action this in the Level04 refactoring, where other script-breaking changes will happen.
@adecler @IsakNaslundBh @al-fisher @epignatelli
The text was updated successfully, but these errors were encountered: