Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligning with changes in BHoMAdapter #78

Merged
merged 3 commits into from
Nov 1, 2019
Merged

Aligning with changes in BHoMAdapter #78

merged 3 commits into from
Nov 1, 2019

Conversation

adecler
Copy link
Member

@adecler adecler commented Oct 31, 2019

NOTE: Depends on

BHoM/BHoM_Adapter#151

Issues addressed by this PR

Closes #77

Updating adapter to align with changes in the parent BHoMAdapter

image

image

Additional comments:

I have implemented the handling of the IResultRequest. See above for a quick test on our HK database

@adecler adecler added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Oct 31, 2019
@adecler adecler added this to the BHoM 3.0 β MVP milestone Oct 31, 2019
@adecler adecler self-assigned this Oct 31, 2019
epignatelli
epignatelli previously approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

alelom
alelom approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@alelom alelom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
EDIT: See my comment below

@alelom alelom self-requested a review October 31, 2019 14:38
alelom
alelom requested changes Oct 31, 2019
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfect, only thing since we are here, could you please create a new folder "AdapterActions" and move the Pull.cs, Push.cs and Execute.cs files from the CRUD folder to there?

Realised I'd like to get some consistency there as well.

@adecler
Copy link
Member Author

adecler commented Nov 1, 2019

I took the liberty to also move the Delete.cs as it is not the CRUD Delete but the adapter Delete.

@adecler adecler mentioned this pull request Nov 1, 2019
Closed
alelom
alelom approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwemay rwemay merged commit 92cbbca into master Nov 1, 2019
@rwemay rwemay deleted the BHoM_Adapter-refactoringLvl3-01 branch November 1, 2019 14:57
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epignatelli epignatelli epignatelli approved these changes

@alelom alelom alelom approved these changes

@emidio-piermarini emidio-piermarini Awaiting requested review from emidio-piermarini

Assignees

@adecler adecler

Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.

Mongo_Toolkit: Adapting to changes in BHoMAdapter
4 participants
@adecler @alelom @epignatelli @rwemay