Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BHoM_Adapter: refactoring-ReplaceThroughAPI-simplification possible #89

Closed
Tracked by #84
alelom opened this issue May 24, 2019 · 1 comment · Fixed by #120
Closed
Tracked by #84

BHoM_Adapter: refactoring-ReplaceThroughAPI-simplification possible #89

alelom opened this issue May 24, 2019 · 1 comment · Fixed by #120
Assignees
@alelom
Labels
type:feature New capability or enhancement
Milestone
BHoM 2.4 β MVP

Comments

@alelom
Copy link
Member

alelom commented May 24, 2019 •
edited
Loading

Proposed change

Simplify the ReplaceThroughAPI method to avoid unnecessary logic. See following diagrams that compare the two logics:

Existing logic

Refactored logic

Depends on

#86
@alelom alelom self-assigned this May 24, 2019
@alelom alelom added the type:feature New capability or enhancement label May 24, 2019
@alelom alelom mentioned this issue May 24, 2019
Open
17 tasks
alelom added a commit that referenced this issue Jul 10, 2019
@alelom
#89-Simplified ReplaceThroughAPI
5ab577b 
Methods has been simplified removing the seceond unneeded Venn Diagram operation and subsequent superflous logic
@alelom alelom added this to the BHoM 2.4 β MVP milestone Aug 20, 2019
@alelom alelom mentioned this issue Aug 20, 2019
Merged
alelom added a commit that referenced this issue Sep 10, 2019
@alelom
#89-Simplified ReplaceThroughAPI
ac0bb50 
Methods has been simplified removing the seceond unneeded Venn Diagram operation and subsequent superflous logic
@alelom
Copy link
Member Author

alelom commented Sep 12, 2019

Closed via #120

@alelom alelom closed this as completed Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alelom alelom

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 2.4 β MVP
Development

Successfully merging a pull request may close this issue.

refactoring-Level1 changes BHoM/BHoM_Adapter
1 participant
@alelom