BHoM_Adapter refactoring Lvl3_01 - workaround to have the CRUD working for non-BHoMObjects #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here the deepclone and the tag addition
…fig and config to pushConfig for clarity.
…). Moved the function back in the Push.
alelom
commented
Oct 7, 2019
BHoM_Adapter/BHoMAdapter.cs
Outdated
Comment on lines
66
to
70
| // Wrap non-BHoM objects into a Custom BHoMObject to make them work as BHoMObjects. | ||
| List<IObject> objectsToPush = Modify.WrapNonBHoMObjects(objects, Config, tag, pushConfig).ToList(); | ||
|
|
||
| // Clone the objects for immutability in the UI. CloneBeforePush should always be true, except for very specific cases. | ||
| objectsToPush = Config.CloneBeforePush ? objects.Select(x => x.DeepClone()).ToList() : objects.ToList(); |
There was a problem hiding this comment.
@IsakNaslundBh the reason for WrapNonBHoMObjects() checking the boolean WrapNonBHoMObjects inside the method itself is because this way we can freely override the default Adapter setting through the Push config.
alelom
added
severity:medium
alelom
changed the title
IsakNaslundBh
requested changes
Oct 8, 2019
IsakNaslundBh
approved these changes
Oct 8, 2019
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #140
Also adds some comments and a few renamings for clarity.
Test script
https://burohappold.sharepoint.com/:u:/s/BHoM/ERekpoPskXFOuC66VS7yG74BFNT5HaGuqKBFTcOj_qRvfw?e=qCF92Q
Changelog
WrapNonBHoMObjects()method. Wraps non-BHoMObjects into Custom BHoM Objects so they can make use of the Adapter Replace/Crud methods as the BHoMObjects (they get an ID, CustomData, etc).AdapterConfig.WrapNonBHoMObjectsthat defines default Toolkit behaviour for that method. Defaults to false, as it should be used only in few specific Toolkits.configboolean option that overrides the defaultAdapterConfigsetting if specified, so the user has control over the specific Push case.