Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated AssemblyVersion and AssemblyFileVersion to 3.0.0.0 #154

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Updated AssemblyVersion and AssemblyFileVersion to 3.0.0.0 #154

merged 1 commit into from
Oct 18, 2019

Conversation

alelom
Copy link
Member

@alelom alelom commented Oct 18, 2019

Issues addressed by this PR

Closes #153

@alelom alelom added the type:compliance Non-conforming to code guidelines label Oct 18, 2019
@alelom alelom added this to the BHoM 3.0 β MVP milestone Oct 18, 2019
@alelom alelom self-assigned this Oct 18, 2019
epignatelli
epignatelli reviewed Oct 18, 2019
View reviewed changes
Copy link
Member

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be for the File_Adapter as well?

epignatelli
epignatelli approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even before!

@alelom alelom merged commit 9d3ea21 into master Oct 18, 2019
@epignatelli epignatelli deleted the #153-UpdateAssemblyInfo branch October 18, 2019 16:02
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epignatelli epignatelli epignatelli approved these changes

@FraserGreenroyd FraserGreenroyd Awaiting requested review from FraserGreenroyd

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

Assignees

@alelom alelom

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.

Update AssemblyVersion and AssemblyFileVersion to 3.0.0.0
2 participants
@alelom @epignatelli