Code

Adapter refactoring Level 04#164

Code

Merged

alelom merged 95 commits intomasterBHoM/BHoM_Adapter:masterfrom BHoM_Adapter-refactoringLvl04-01BHoM/BHoM_Adapter:BHoM_Adapter-refactoringLvl04-01Copy head branch name to clipboardJan 24, 2020

+2,512-555

Commits

Commits on Nov 11, 2019

• Moved ReadResult into its own file

  alelom

  committed
  df7b0fe

  Copy full SHA for df7b0fe

• New folder structure: CRUDCallers and Extra. New methods: CreateOnly, DependenciesCreateOnly, DependenciesUpdateOnly

  alelom

  committed
  6a97254

  Copy full SHA for 6a97254

• WrapNonBHoMObjects now accepts object and modifies the list by reference

  Show description for aaddddc
  alelom

  committed
  aaddddc

  Copy full SHA for aaddddc

Commits on Nov 13, 2019

• Create and Update now accept only IBHoMObjects for consistency

  Show description for 160436d
  alelom

  committed
  160436d

  Copy full SHA for 160436d

• Rename UpdateObjects to Update

  alelom

  committed
  bb753ae

  Copy full SHA for bb753ae

Commits on Nov 14, 2019

• Minor comment adjustments

  alelom

  committed
  7184927

  Copy full SHA for 7184927

• Added PushOption enum parameter to Push. Push uses it.

  alelom

  committed
  0b1bd6c

  Copy full SHA for 0b1bd6c

• 1. Renamed Config to AdapterSettings. 2. Added PushOption & PullOption

  alelom

  committed
  43efc5a

  Copy full SHA for 43efc5a

• Tidy up and corrections

  alelom

  committed
  c5ca3ee

  Copy full SHA for c5ca3ee

• Renamed the AdapterAction Delete to Remove.

  alelom

  committed
  03dc8e8

  Copy full SHA for 03dc8e8

• The AdapterId property is now auto-initialised with the derived class name. #163

  Show description for 850e81a
  alelom

  committed
  850e81a

  Copy full SHA for 850e81a

• 1) Changes in folder/files arrangement following chat with @al-fisher. 2) Added ActionConfig global property and logic to reset it at the start of each AdapterAction (except Move).

  alelom

  committed
  0c24574

  Copy full SHA for 0c24574

• Removed init logic for the config Dictionary from the Actions. It is now in BHoM_UI (except for the Move, which must have it here)

  alelom

  committed
  92a2b01

  Copy full SHA for 92a2b01

Commits on Nov 15, 2019

• Added Adapter_oM and Adapter_Engine projects -> moved files. Comments.

  alelom

  committed
  ce1f69f

  Copy full SHA for ce1f69f

• Corrected default namespaces, build folder and copy locals for the new projects.

  alelom

  committed
  d121a5c

  Copy full SHA for d121a5c

• Merge branch 'master' into BHoM_Adapter-refactoringLvl04-01

  alelom

  committed
  0ffe1fd

  Copy full SHA for 0ffe1fd

• Minor rewriting of a comment

  alelom

  committed
  8784c8b

  Copy full SHA for 8784c8b

• Minor constructor and properties tidy up.

  alelom

  committed
  14a2663

  Copy full SHA for 14a2663

Commits on Nov 20, 2019

• Minor comment tidy-ups

  alelom

  committed
  73c2434

  Copy full SHA for 73c2434

• First introduction of Adapter ID Fragment

  alelom

  committed
  5ffa21c

  Copy full SHA for 5ffa21c

• New take on IdFragment.

  alelom

  committed
  feb314b

  Copy full SHA for feb314b

• Simpler iteration on AdapterIdFragment.

  alelom

  committed
  5e2176d

  Copy full SHA for 5e2176d

Commits on Nov 22, 2019

• Several items. See commit description.

  Show description for f1d601b
  alelom

  committed
  f1d601b

  Copy full SHA for f1d601b

• Tidy up.

  Show description for fdb1c09
  alelom

  committed
  fdb1c09

  Copy full SHA for fdb1c09

Commits on Nov 25, 2019

• Comment in PortProperties

  alelom

  committed
  9990928

  Copy full SHA for 9990928

• Minor comment changes

  alelom

  committed
  5efe008

  Copy full SHA for 5efe008

• Return RecordError for non-overridden Read/Delete/Create overloads

  alelom

  committed
  fdd97f1

  Copy full SHA for fdd97f1

Commits on Nov 27, 2019

• Renamed Pushtype files

  alelom

  committed
  e299bb0

  Copy full SHA for e299bb0

Commits on Nov 28, 2019

• Max level of modification. Next I will reduce it for wrapping up.

  alelom

  committed
  2c79378

  Copy full SHA for 2c79378

• Update FullCRUD.cs

  alelom

  committed
  51dba6f

  Copy full SHA for 51dba6f

• Main wrap up done.

  alelom

  committed
  61eb22c

  Copy full SHA for 61eb22c

• Further Wrap up refactor.

  alelom

  committed
  965f3ea

  Copy full SHA for 965f3ea

• Introduced StructuralAnalysisAdapter project.

  alelom

  committed
  dec98cb

  Copy full SHA for dec98cb

• Minor corrections.

  alelom

  committed
  1188db1

  Copy full SHA for 1188db1

• Refactor to allow IdFragment.

  alelom

  committed
  1ba5167

  Copy full SHA for 1ba5167

Commits on Nov 29, 2019

• Included all suggestions from final review + AdapterId has non-generic Fragment.

  alelom

  committed
  fe90355

  Copy full SHA for fe90355

Commits on Dec 4, 2019

• Some renaming; comparers and dependencytypes are now protected fields with backing default Get method

  alelom

  committed
  a0c3cdb

  Copy full SHA for a0c3cdb

• corrections

  alelom

  committed
  f7fff6c

  Copy full SHA for f7fff6c

• Final wrap up. Changes aligned in GSA_Toolkit too.

  alelom

  committed
  c776e32

  Copy full SHA for c776e32

• Minor refactor

  alelom

  committed
  72a7fef

  Copy full SHA for 72a7fef

• Added Default comparer with Hash

  alelom

  committed
  c85e54f

  Copy full SHA for c85e54f

Commits on Dec 10, 2019

• Inverted order of configs to be clearer in aligment instructions

  alelom

  committed
  c7604ee

  Copy full SHA for c7604ee

Commits on Dec 11, 2019

• Updated descriptions for PushType and PullType

  alelom

  committed
  d986918

  Copy full SHA for d986918

Commits on Jan 9, 2020

• Corrected null check missing in GetComparerForType.cs

  alelom

  committed
  4d70274

  Copy full SHA for 4d70274

• Introduction of AdapterModules. Folder rearrangement.

  alelom

  committed
  08778ed

  Copy full SHA for 08778ed

• Added description to ModuleLoader

  alelom

  committed
  bdf793d

  Copy full SHA for bdf793d

• Changes as per @IsakNaslundBh suggestions. Added ModuleSet.

  alelom

  committed
  fd37317

  Copy full SHA for fd37317

• Updated Assembly version

  alelom

  committed
  ae2de7e

  Copy full SHA for ae2de7e

Commits on Jan 13, 2020

• AdapterComparers and DependencyTypes now public properties; methods to get them moved in Engine.

  alelom

  committed
  28f12ab

  Copy full SHA for 28f12ab

• CustomData.ContainsKey check in CopyBHoMObjectProperties

  alelom

  committed
  003166e

  Copy full SHA for 003166e

Commits on Jan 14, 2020

• Removed unused class OrderedHashSet. Copy locals to false.

  Show description for c1558ac
  alelom

  committed
  c1558ac

  Copy full SHA for c1558ac

• IBHoMAdapter is no longer IObject; added in Action methods

  alelom

  committed
  b9cea35

  Copy full SHA for b9cea35

• Removed IImmutable from BHoMAdapter inheritance

  alelom

  committed
  689b204

  Copy full SHA for 689b204

• Update Move.cs

  alelom

  committed
  e0526b2

  Copy full SHA for e0526b2

• Hash for comparers defaulted to false.

  alelom

  committed
  e52b087

  Copy full SHA for e52b087

• FullCRUD now calls GetCopyPropertyModules. Rewritten latter.

  alelom

  committed
  52c98f6

  Copy full SHA for 52c98f6

• Removed all WIP fragment-related stuff. Will be for next refactoring.

  alelom

  committed
  1f9313b

  Copy full SHA for 1f9313b

• Removed redundant inheritance of IBHoMAdapter

  alelom

  committed
  eccc2e1

  Copy full SHA for eccc2e1

• #175 Execute now returns Output<object, bool>

  alelom

  committed
  882c40b

  Copy full SHA for 882c40b

• Added IExecuteCommand interface and few related commands.

  alelom

  committed
  d6517b8

  Copy full SHA for d6517b8

Commits on Jan 15, 2020

• Corrected a few descriptions.

  alelom

  committed
  883ae66

  Copy full SHA for 883ae66

• Added further description to the output of Execute

  alelom

  committed
  d9efd62

  Copy full SHA for d9efd62

Commits on Jan 16, 2020

• Execute returns Output<List<object>, bool>

  alelom

  committed
  2de1177

  Copy full SHA for 2de1177

• Updated command descriptions

  alelom

  committed
  98c0466

  Copy full SHA for 98c0466

• New take on IAdapterSettings and IActionConfig.

  alelom

  committed
  0e84335

  Copy full SHA for 0e84335

• Add IAdapterSettings and IActionConfig; descriptions to clarify.

  alelom

  committed
  864bfa3

  Copy full SHA for 864bfa3

• Revert "Add IAdapterSettings and IActionConfig; descriptions to clarify."

  Show description for c2a0859
  alelom

  committed
  c2a0859

  Copy full SHA for c2a0859

• Revert "New take on IAdapterSettings and IActionConfig."

  Show description for 4b375b9
  alelom

  committed
  4b375b9

  Copy full SHA for 4b375b9

• Added some descriptions for Config and Settings

  alelom

  committed
  31cd674

  Copy full SHA for 31cd674

• ActionConfig and AdapterSettings now inherit from IObject

  alelom

  committed
  1bc7d54

  Copy full SHA for 1bc7d54

Commits on Jan 17, 2020

• Update Close.cs

  alelom

  committed
  90df51e

  Copy full SHA for 90df51e

• Update Close.cs

  alelom

  committed
  003f044

  Copy full SHA for 003f044

• Update Close.cs

  alelom

  committed
  bce83bd

  Copy full SHA for bce83bd

• Added few descriptions.

  alelom

  committed
  87973f9

  Copy full SHA for 87973f9

• Added distinct in the CreateOnly method.

  alelom

  committed
  51436c8

  Copy full SHA for 51436c8

Commits on Jan 21, 2020

• Moved ExecuteCommands folder one level up in the oM.

  alelom

  committed
  89d0d18

  Copy full SHA for 89d0d18

• Changed AnalyseLoadCases command to take List<object>

  alelom

  committed
  691fd19

  Copy full SHA for 691fd19

• Update AnalyseLoadCases.cs

  alelom

  committed
  b7a038c

  Copy full SHA for b7a038c

• Corrected invokation of IUpdate in FullCRUD. Added Runtime Note.

  alelom

  committed
  7fed05b

  Copy full SHA for 7fed05b

• Updated RecordNote text

  alelom

  committed
  e3fb591

  Copy full SHA for e3fb591

• Updated AnalyseLoadCases description

  alelom

  committed
  36bf23a

  Copy full SHA for 36bf23a

• Null guards for things returned from Read methods.

  alelom

  committed
  0f959f5

  Copy full SHA for 0f959f5

• Simplified null guards

  alelom

  committed
  da45cf6

  Copy full SHA for da45cf6

Commits on Jan 22, 2020

• Reviewed CreateOnly. UpdateOnly minor changes. Renamed CRUD() TO FullCRUD().

  alelom

  committed
  94cbdf9

  Copy full SHA for 94cbdf9

• Added AdapterSetting for CreateOnly(): control over Distinct() on objects&dependencies

  alelom

  committed
  2ae9267

  Copy full SHA for 2ae9267

• Reviewed description for ActionConfig

  alelom

  committed
  19371f0

  Copy full SHA for 19371f0

• Added descriptions.

  alelom

  committed
  7ce164f

  Copy full SHA for 7ce164f

• Update create only to make it able to be recursive

  IsakNaslundBh

  committed
  a84f6e2

  Copy full SHA for a84f6e2

• Adding missing action configs in UpdateOnly and FullCRUD

  IsakNaslundBh

  committed
  8bfeb08

  Copy full SHA for 8bfeb08

• Added few missing ActionConfig parameters.

  alelom

  committed
  9f2cfc1

  Copy full SHA for 9f2cfc1

• Added few more descriptions and renamed the bool "distinct" in CreateOnly

  alelom

  committed
  c63c7df

  Copy full SHA for c63c7df

• corrected tagging

  alelom

  committed
  ebe1a66

  Copy full SHA for ebe1a66

• Added missing ActionConfig parameters in ReadResult methods

  alelom

  committed
  5de00c7

  Copy full SHA for 5de00c7

• Update Pull.cs

  alelom

  committed
  c78c00a

  Copy full SHA for c78c00a

• Update Pull.cs

  alelom

  committed
  515977e

  Copy full SHA for 515977e