Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: Offset polyLine not working as expected #3235

Closed
KalleEdstroem opened this issue Jan 10, 2024 · 2 comments · Fixed by #3394
Closed

Geometry_Engine: Offset polyLine not working as expected #3235

KalleEdstroem opened this issue Jan 10, 2024 · 2 comments · Fixed by #3394
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@KalleEdstroem
Copy link

KalleEdstroem commented Jan 10, 2024

Description:

Used offset method on a PolyLine object.
Which created a "dent" in the PolyLine output.

offset issue

Problems occurs in this method:

public static Polyline Offset(this Polyline curve, double offset, Vector normal = null, bool tangentExtensions = false, double tolerance = Tolerance.Distance)

Steps to reproduce:

Test script shows issue.

Expected behaviour:

Expected behavior is that the offset output keeps the same shape as the input. Behavs same as the Rhino version of offset shown in testscript.

Test file(s):

https://burohappold.sharepoint.com/sites/BHoM/02_Current/Forms/AllItems.aspx?id=%2Fsites%2FBHoM%2F02%5FCurrent%2F12%5FScripts%2F01%5FIssue%2FBHoM%2FBHoM%5FEngine%2FGeometry%5FEngine%2F%233235%2DOffsetProducingDentICurve%2Egh&viewid=a5a93cba%2Dfcca%2D46cc%2Da31a%2D80b8d5cbfd7b&parent=%2Fsites%2FBHoM%2F02%5FCurrent%2F12%5FScripts%2F01%5FIssue%2FBHoM%2FBHoM%5FEngine%2FGeometry%5FEngine

@KalleEdstroem KalleEdstroem added the type:bug Error or unexpected behaviour label Jan 10, 2024
@FraserGreenroyd
Copy link
Contributor

@KalleEdstroem is this not covered by #1333 ?

@KalleEdstroem
Copy link
Author

I would guess that the things mentioned in #1333 are the reasons why this bug is occurring.

@peterjamesnugent peterjamesnugent changed the title Offset polyLine not working as expected Geometry_Engine: Offset polyLine not working as expected Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants