Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine DeepClone modify Methods #1266

Conversation

MajaLindroth
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #1265

Added DeepClone to modify Methods

Test files

Existing test files

Changelog

  • Update modify methods to prevent upstream object changes

Additional comments

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @MajaLindroth - now we can edit items without editing the upstream object, this should help a lot of the visual programming users 😄

image

@FraserGreenroyd FraserGreenroyd merged commit b44ddf3 into BHoM:master Oct 17, 2019
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#1265-DeepClone-Methods branch October 17, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine modify methods should DeepClone
2 participants