Geometry_Engine: Create.Ellipse() unnormalised axes bug #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2019 10:05
LMarkowski
added
severity:low
LMarkowski
requested review from
FraserGreenroyd,
IsakNaslundBh and
pawelbaran
pawelbaran
approved these changes
Oct 29, 2019
al-fisher
deleted the
Geometry_Engine#1287CreateEllipseNoramliseAxesBug
branch
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #1287
Create.Ellipse was taking any input axes. Now the vectors are being normalised to prevent errors during further manipulations. Also a check if they are orthogonal is added.
Test files
Test file from the issue is enough.
Changelog
Create.Ellipse()public method was updated inGeometry.Engine()Additional comments