Data_Engine: Adding create methods and first query methods for Table class #1289

IsakNaslundBh · 2019-10-29T14:06:18Z

NOTE: Depends on

Issues addressed by this PR

Adding create methods and first Query methods for Tables.

Please note that the DataTable can not be serialised to Bson by default. I have code ready for this, but will need to be aligned with the work done by @adecler in #1270

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/BHoM_Engine/Data_Engine/Issue_1289_CreateTables?csf=1&e=KcLoUo

Changelog

Adding Create method for table class. One from List<IBHoMObject> and one from 2D table with header values.
Query method for getting table rows matching exact values in table
Query method for getting table rows matching values above set axis-values

Additional comments

@Martian42

epignatelli · 2019-10-31T11:18:50Z

Data_Engine/Create/Table.cs

+
+        /***************************************************/
+
+        [Description("")]


Are these going to be filled? If not, we can remove them?

Thanks @epignatelli , yes, need to get all of these filled in.

epignatelli · 2019-10-31T11:22:10Z

Data_Engine/Query/Axes.cs

+        /**** Public Methods                            ****/
+        /***************************************************/
+
+        [Description("")]


epignatelli · 2019-10-31T11:23:34Z

Data_Engine/Create/Table.cs

+        [Description("")]
+        [Input("", "")]
+        [Output("", "")]
+        public static Table Table<T>(string name, string axis1Name, List<IComparable> axis1Values, string axis2Name, List<IComparable> axis2Values, List<List<T>> values, string valuesName = "Values")


What is an IComparable exactly? Can we input it from the UI side of things?
Not commenting all the rest, it's in other places as well.

IsakNaslundBh · 2019-11-07T10:01:49Z

@adecler , would not mind a review from you on this, especially on the Serialiser_Engine part.

Also removing old generic argument for Axis method

adecler

The serialiser looks fine to me.
I did a back and forth to and from Json and no data was lost.
See comment on the code though.

adecler · 2019-11-08T02:58:03Z

Data_Engine/Create/Table.cs

+            foreach (var kvp in properties)
+            {
+
+                columns.Add(new DataColumn(kvp.Key, kvp.Value.GetType()));


This needs a null check:

IsakNaslundBh · 2019-11-14T09:04:11Z

Pinging this!

Would anyone please be able to have a look at this PR so we can get it merged. Thanks!

FraserGreenroyd · 2019-11-14T09:08:34Z

Sorry @IsakNaslundBh yes I'll try and get on this today!

FraserGreenroyd · 2019-11-14T09:11:47Z

/azp run BHoM.CheckCore

azure-pipelines · 2019-11-14T09:11:52Z

No pipelines are associated with this pull request.

FraserGreenroyd · 2019-11-14T09:12:26Z

/azp run BHoM_Engine.CheckCore

azure-pipelines · 2019-11-14T09:12:35Z

Azure Pipelines successfully started running 1 pipeline(s).

FraserGreenroyd · 2019-11-14T09:14:13Z

No pipelines are associated with this pull request.

Good to know, thanks bot 🤦‍♂

al-fisher · 2019-11-14T09:24:40Z

No pipelines are associated with this pull request.

Good to know, thanks bot 🤦‍♂

@FraserGreenroyd it is the beginning of the end! 🤖
😆

FraserGreenroyd

On the whole this looks ok from a code perspective - some comments in the code for tidiness as discussed @IsakNaslundBh .

Will run test scripts now.

Data_Engine/Query/Axes.cs

Data_Engine/Create/Table.cs

FraserGreenroyd · 2019-11-14T09:31:42Z

No pipelines are associated with this pull request.

Good to know, thanks bot 🤦‍♂

@FraserGreenroyd it is the beginning of the end! 🤖
😆

Skynet here we come... time to build a bunker! tinfoil hat firmly placed

FraserGreenroyd · 2019-11-14T09:41:26Z

Test script worked with some modifications (I think the GH file was slightly out of date to the latest code, but replacing the components worked fine for me), so am happy to approve this PR when the above code comments are addressed @IsakNaslundBh 😄

IsakNaslundBh · 2019-11-14T10:43:11Z

Thanks @FraserGreenroyd 🚀

Have fixed your white space comments. Also added a method to get all data out from the table. Added that method to the testscript as well and updated the outdated components.

FraserGreenroyd

This LGTM @IsakNaslundBh - good to see where this grows 😄

FraserGreenroyd · 2019-11-14T11:05:14Z

/azp run BHoM_Engine.CheckInstaller

azure-pipelines · 2019-11-14T11:05:24Z

Azure Pipelines successfully started running 1 pipeline(s).

Adding create methods and first query methods for Table class

83c541e

IsakNaslundBh added the type:feature New capability or enhancement label Oct 29, 2019

IsakNaslundBh added this to the BHoM 3.0 β MVP milestone Oct 29, 2019

IsakNaslundBh requested review from rwemay, al-fisher, adecler and FraserGreenroyd October 29, 2019 14:06

IsakNaslundBh requested a review from epignatelli as a code owner October 29, 2019 14:06

IsakNaslundBh self-assigned this Oct 29, 2019

IsakNaslundBh added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Oct 29, 2019

epignatelli reviewed Oct 31, 2019

View reviewed changes

IsakNaslundBh added 2 commits November 7, 2019 10:14

Merge branch 'master' into Data_oM-#593-AddTableClass

ef11fa9

Adding Serialisation for DataTable

c4b86e7

IsakNaslundBh added 8 commits November 7, 2019 11:29

Adding descriptions for ValuesAt

65fd87a

Adding descriptions for ValuesAbove

6364932

Adding descriptions to axes

4a9c88d

Adding AxisExists method

f37d0a0

Also removing old generic argument for Axis method

Adding checks for table axis for extractions

4b1d8cf

Updating descriptions

c0df5e1

IComparable -> object

ab76d6d

Adding descriptions to the Create methods for the Table

3acaa9d

adecler mentioned this pull request Nov 8, 2019

Data_Engine: Enable advanced sorting and filtering BHoM object lists, by wrapping 'Linq' methods #1312

Merged

adecler reviewed Nov 8, 2019

View reviewed changes

Adding property type dictionary to create method for the tables

e8c83d3

IsakNaslundBh removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Nov 8, 2019

FraserGreenroyd requested review from adecler and epignatelli November 8, 2019 19:53

FraserGreenroyd reviewed Nov 14, 2019

View reviewed changes

IsakNaslundBh added 2 commits November 14, 2019 11:35

Fixing whitespace

0fca05a

Adding method to get all values from a table

fe8dbd9

FraserGreenroyd approved these changes Nov 14, 2019

View reviewed changes

IsakNaslundBh merged commit 6d94d5e into master Nov 14, 2019

IsakNaslundBh deleted the Data_oM-#593-AddTableClass branch November 14, 2019 11:18

This was referenced Dec 19, 2019

Change Log for 3.0 beta BHoM full FraserGreenroyd/SAMAzure#32

Closed

3.0 beta change log OS BHoM FraserGreenroyd/SAMAzure#33

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Data_Engine: Adding create methods and first query methods for Table class #1289

Data_Engine: Adding create methods and first query methods for Table class #1289

IsakNaslundBh commented Oct 29, 2019 •

edited

Loading

epignatelli Oct 31, 2019

IsakNaslundBh Oct 31, 2019

epignatelli Oct 31, 2019

epignatelli Oct 31, 2019

IsakNaslundBh commented Nov 7, 2019

adecler left a comment

adecler Nov 8, 2019

IsakNaslundBh commented Nov 14, 2019

FraserGreenroyd commented Nov 14, 2019

FraserGreenroyd commented Nov 14, 2019

azure-pipelines bot commented Nov 14, 2019

FraserGreenroyd commented Nov 14, 2019

azure-pipelines bot commented Nov 14, 2019

FraserGreenroyd commented Nov 14, 2019

al-fisher commented Nov 14, 2019

FraserGreenroyd left a comment

FraserGreenroyd commented Nov 14, 2019

FraserGreenroyd commented Nov 14, 2019

IsakNaslundBh commented Nov 14, 2019

FraserGreenroyd left a comment

FraserGreenroyd commented Nov 14, 2019

azure-pipelines bot commented Nov 14, 2019


		/***************************************************/

		[Description("")]

Data_Engine: Adding create methods and first query methods for Table class #1289

Data_Engine: Adding create methods and first query methods for Table class #1289

Conversation

IsakNaslundBh commented Oct 29, 2019 • edited Loading

NOTE: Depends on

Issues addressed by this PR

Test files

Changelog

Additional comments

epignatelli Oct 31, 2019

Choose a reason for hiding this comment

IsakNaslundBh Oct 31, 2019

Choose a reason for hiding this comment

epignatelli Oct 31, 2019

Choose a reason for hiding this comment

epignatelli Oct 31, 2019

Choose a reason for hiding this comment

IsakNaslundBh commented Nov 7, 2019

adecler left a comment

Choose a reason for hiding this comment

adecler Nov 8, 2019

Choose a reason for hiding this comment

IsakNaslundBh commented Nov 14, 2019

FraserGreenroyd commented Nov 14, 2019

FraserGreenroyd commented Nov 14, 2019

azure-pipelines bot commented Nov 14, 2019

FraserGreenroyd commented Nov 14, 2019

azure-pipelines bot commented Nov 14, 2019

FraserGreenroyd commented Nov 14, 2019

al-fisher commented Nov 14, 2019

FraserGreenroyd left a comment

Choose a reason for hiding this comment

FraserGreenroyd commented Nov 14, 2019

FraserGreenroyd commented Nov 14, 2019

IsakNaslundBh commented Nov 14, 2019

FraserGreenroyd left a comment

Choose a reason for hiding this comment

FraserGreenroyd commented Nov 14, 2019

azure-pipelines bot commented Nov 14, 2019

IsakNaslundBh commented Oct 29, 2019 •

edited

Loading