Serialiser_Engine: Improve on the handling of deprecated and inexistent classes #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecler
requested review from
alelom,
rwemay,
al-fisher,
FraserGreenroyd,
IsakNaslundBh and
epignatelli
…liser fails (inside of object changed)
FraserGreenroyd
pushed a commit
that referenced
this pull request
Nov 4, 2019
Update Diffing_Engine to handle query from Testing_Engine
FraserGreenroyd
changed the title
FraserGreenroyd
pushed a commit
that referenced
this pull request
Nov 4, 2019
Update Diffing_Engine to handle query from Testing_Engine
FraserGreenroyd
approved these changes
Nov 5, 2019
adecler
deleted the
Serialiser_Engine-#1290-ImproveForDeprecatedAndInexistent
branch
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/Versioning_Toolkit#4
Issues addressed by this PR
Closes #1290
See BHoM/Versioning_Toolkit#4 for more details
Additional comments
This PR provide the necesseray interaction with the new version of the versioning engine and greatly simplify the whole process (code deletion is back!!)