Environment_Engine: Explose Tilt tolerance parameters #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraserGreenroyd
changed the title
FraserGreenroyd
requested changes
Nov 5, 2019
There was a problem hiding this comment.
This looks good @MajaLindroth - some minor comments:
- Can we pass
distanceToleranceto theIsClosedmethod - Can we pass
distanceToleranceto theIsPlanarmethod - Can we pass
angleToleranceto theCleanPolylinemethod - Can we pass
distanceToleranceto theIsClockwisemethod
Tack!
FraserGreenroyd
deleted the
Environment_Engine-#1273-Tolerance-Parameters-of-Tilt
branch
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #1273
Added distanceTolerance and angleTolerance as input parameters for the Tilt methods.
Test files
Changelog
Additional comments