Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment_Engine: Adding manipulation and query methods #1304

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Environment_Engine: Adding manipulation and query methods #1304

merged 1 commit into from
Nov 6, 2019

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #1303

Test files

Standard test scripts

Changelog

  • Add function to remove openings
  • Add function to split a single opening into multiple openings
  • Add function to split a single panel into multiple panels
  • Add function to query an opening from a collection of openings by its name

Additional comments

@FraserGreenroyd FraserGreenroyd added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement labels Nov 6, 2019
@FraserGreenroyd FraserGreenroyd self-assigned this Nov 6, 2019
michaldengusiak
michaldengusiak approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@michaldengusiak michaldengusiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build fine,

@FraserGreenroyd FraserGreenroyd merged commit 3611d50 into master Nov 6, 2019
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#1303-ModifyMethods branch November 6, 2019 10:12
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldengusiak michaldengusiak michaldengusiak approved these changes

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

@MajaLindroth MajaLindroth Awaiting requested review from MajaLindroth

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Add ability to remove openings
2 participants
@FraserGreenroyd @michaldengusiak