Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: Add fallback cases and support for Basis in Clone.cs #1308

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

adecler
Copy link
Member

@adecler adecler commented Nov 7, 2019

Issues addressed by this PR

Closes #1307

Test files

image

Additional comments

  • This was actually highlighted when trying to add default value for each input of the new CreateObject component (see Refine the CreateObject component BHoM_UI#152)
  • I suppose it might be worth checking if other geometry methods are missing support for Basis and fallback method. Something to fix in another PR though as this one is purely to make sure the UI PR is not held up because of this.

@adecler adecler added the type:bug Error or unexpected behaviour label Nov 7, 2019
@adecler adecler added this to the BHoM 3.0 β MVP milestone Nov 7, 2019
@adecler adecler self-assigned this Nov 7, 2019
Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adecler
LGTM

@al-fisher al-fisher merged commit c0d1a1f into master Nov 8, 2019
@al-fisher al-fisher deleted the Geometry_Engine-#1307-FixClassesCoveredByClone branch November 8, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: Clone doesn't cover all possible geometry
2 participants