Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BHoM_Engine: Removing legacy projects #1366

Merged
merged 1 commit into from
Dec 3, 2019
Merged

BHoM_Engine: Removing legacy projects #1366

merged 1 commit into from
Dec 3, 2019

Conversation

adecler
Copy link
Member

@adecler adecler commented Dec 3, 2019

Issues addressed by this PR

Closes #1234

Test files

Just make sure everything still compiles

Changelog

  • BHoM_Engine_Legacy: removed from BHoM engine
  • Engine_Explore: removed from BHoM engine
  • MachineLearning_Engine: moved to its own repository
  • StadiaCrowdAnalysis_Engine: moved to its own repository

Additional comments

Fraser, I hope the changelog format works for you. Feel free to change otherwise 😄

@adecler adecler added the type:compliance Non-conforming to code guidelines label Dec 3, 2019
@adecler adecler added this to the BHoM 3.0 β MVP milestone Dec 3, 2019
@adecler adecler self-assigned this Dec 3, 2019
@FraserGreenroyd
Copy link
Contributor

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

FraserGreenroyd
FraserGreenroyd approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, compiles fine independently and as part of the wider group on my machine (just running the installer check now to confirm the installer status as well but I'm not anticipating any problems).

Am happy with the change log on this one as well 😄

@adecler adecler merged commit 5540cc5 into master Dec 3, 2019
@adecler adecler deleted the BHoM_Engine-#1234-RemovingLegacyProjects branch December 3, 2019 09:24
@adecler adecler restored the BHoM_Engine-#1234-RemovingLegacyProjects branch December 4, 2019 02:29
@adecler adecler deleted the BHoM_Engine-#1234-RemovingLegacyProjects branch December 4, 2019 02:30
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@epignatelli epignatelli Awaiting requested review from epignatelli

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

Assignees

@adecler adecler

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.

Engine_Explore: delete this project
2 participants
@adecler @FraserGreenroyd