Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1372 #1373

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Fixes #1372 #1373

merged 1 commit into from
Dec 4, 2019

Conversation

epignatelli
Copy link
Member

@epignatelli epignatelli commented Dec 4, 2019 •
edited
Loading

Issues addressed by this PR

Closes #1372

Test procedure

  1. Create a grasshopper file that has a a SocketAdapter in it.
  2. Compile the current branch of the BHoM_Engine and the BHoM_UI
  3. Open the Socket_Toolkit, and and the Deprecated attribute to the SocketAdapter class
  4. Reopen the file you created at 1.
  5. Check that it has the "OLD" label on it.

Changelog

  • Engine.Reflection.IsDeprecated(MethodBase) now also checks if the class is deprecated

Additional comments

@epignatelli epignatelli added severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour labels Dec 4, 2019
@epignatelli epignatelli self-assigned this Dec 4, 2019
tg359
tg359 approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@epignatelli
Copy link
Member Author

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd FraserGreenroyd merged commit ba775cc into master Dec 4, 2019
@FraserGreenroyd FraserGreenroyd deleted the Reflection_Engine-#1372-FixIsDeprecatedForMethodBases branch December 4, 2019 12:33
@IsakNaslundBh IsakNaslundBh mentioned this pull request Dec 5, 2019
Closed
@alelom alelom mentioned this pull request Dec 5, 2019
Merged
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg359 tg359 tg359 approved these changes

@adecler adecler Awaiting requested review from adecler adecler is a code owner

@FraserGreenroyd FraserGreenroyd Awaiting requested review from FraserGreenroyd FraserGreenroyd is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

Assignees

@epignatelli epignatelli

Labels
severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated class still showing up
3 participants
@epignatelli @tg359 @FraserGreenroyd