Revert "Fixes #1372"

[IsakNaslundBh]

Issues addressed by this PR

Closes #1376

This reverts commit ba775cc.

Reverting previously merged commit due to problems in GH

Test files

Changelog

Additional comments

[IsakNaslundBh]

/azp run BHoM_Engine.CheckInstaller

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[epignatelli]

LGTM

[FraserGreenroyd]

What is the plan the resolve the issue this fix originally handled? I can't see that here, while I accept this fix has caused some unintended consequences that our current CI can't catch, we shouldn't just revert a fix without a transparent plan for resolving the original issue.

[IsakNaslundBh]

What is the plan the resolve the issue this fix originally handled? I can't see that here, while I accept this fix has caused some unintended consequences that our current CI can't catch, we shouldn't just revert a fix without a transparent plan for resolving the original issue.

The plan is to re-raise the previous PR again and make sure it works as expected as well as making sure GH works.
Right now no engine component is loaded up in GH when building from master as well as using last night alpha installer.

The suggested action is:

1. Revert this as much more critical to have Engine loading in GH at all
2. Re-open the previously merged issue and make a new PR ensuring this does not happen

[FraserGreenroyd]

Am happy with response provided, if we can get that issue reopened ASAP so it's not lost that's be great.

[alelom]

Am happy with response provided, if we can get that issue reopened ASAP so it's not lost that's be great.

Issue reopened by @IsakNaslundBh
new PR targeting that #1378

[al-fisher]

Thanks @IsakNaslundBh, @epignatelli, all, for working to swiftly to resolve this as it emerged. Well done!
Good to capture some planned improvements to testing procedure (there are always improvements to be made! Even as we continue to make massive advances!) to reduce further likelihood of this!
Will raise an issue for discussion and any additions for next quarter!
Great stuff 👍