Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflection_Engine: Make sure PropertyInfo have a line describing their type #1388

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

adecler
Copy link
Member

@adecler adecler commented Dec 17, 2019

Issues addressed by this PR

This completes PR BHoM/BHoM_UI#173

Additional comments

I have taken the liberty to also include the namespace of a type description when this is a BHoM object. This should help clarifying further how to generate objects for given inputs.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, works as excepted at providing default descriptions to help users and additional descriptions where provided.

image

image

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me as well.

Not sure how useful the "X is a property of Y" text is, as that should be very implicit by the use of a property assignment create, but happy to keep it if others think it should stay.

@adecler
Copy link
Member Author

adecler commented Dec 18, 2019

/azp run BHoM_UI.CheckInstaller

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@adecler
Copy link
Member Author

adecler commented Dec 18, 2019

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adecler
Copy link
Member Author

adecler commented Dec 18, 2019

/azp run BHoM_Engine.CheckCore

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adecler adecler merged commit 5a42c50 into master Dec 18, 2019
@adecler adecler deleted the BHoM_UI-#172-DefaultDescriptions branch December 18, 2019 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants