Environment_Engine Change tolerance default for FloorGeometry #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraserGreenroyd
requested changes
Dec 17, 2019
There was a problem hiding this comment.
This needs a slight documentation change, sorry @MajaLindroth
| @@ -42,8 +42,9 @@ public static partial class Query | |||
|
|
|||
| [Description("Returns the floor geometry of a space represented by Environment Panels as a BHoM Geometry Polyline")] | |||
| [Input("panelsAsSpace", "A collection of Environment Panels that represent a closed space")] | |||
| [Input("tolerance", "Distance tolerance for planar checks, default set to BH.oM.Geometry.Tolerance.Distance")] | |||
There was a problem hiding this comment.
The tolerance in this instance is actually for the BooleanUnion of the floor lines, rather than planar checks 😄
FraserGreenroyd
approved these changes
Dec 17, 2019
|
/azp run BHoM_Engine.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FraserGreenroyd
deleted the
Environment_Engine-#1389-FloorGeometry-Tolerance
branch
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #1389
Change tolerance default to be BH.oM.Geometry.Tolerance.Distance for FloorGeometry query method.
Add input description.
Test files
Changelog