-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment_Engine: Check for directory in ExportEPW #2787
Conversation
…ge is it doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Engine specified in PR title is incorrect, please specify the correct engine that is receiving the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in GH. The following failed the new check when they should have passed:
- A file existing that exactly matches the outputPath variable
- A folder and a new file, where the folder is already existing
@BHoMBot check versioning |
@robinflyman to confirm, the following checks are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check core |
@FraserGreenroyd to confirm, the following checks are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with valid path, path without filename, and path with filename and non-existing directory path. All now behave as expected.
@BHoMBot check required |
@jamesramsden-bh to confirm, the following checks are now queued:
|
The check |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 310 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is core. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6304860759 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 306 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 306 requests in the queue ahead of you. |
Closes #2775
Added a check for a valid directory and a error message if it doesn't exist.