-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physical_Engine: Fix typo and punctuations #2788
Physical_Engine: Fix typo and punctuations #2788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All typos fixed by inspection. No code changed. All seems compliant.
@BHoMBot check required |
@jamesramsden-bh to confirm, the following checks are now queued:
There are 12 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please specify the primary engine being updated by these changes in the PR title.
Some of the descriptions on some of those methods are absolutely ridiculous, but I know that's not down to you @robinflyman and is outside the scope of this PR but yikes can we do a session on revamping these at some point when there's some downtime @jamesramsden-bh @IsakNaslundBh
@FraserGreenroyd to confirm, the following checks are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes have been made.
FAO: @FraserGreenroyd The check they wish to have dispensation on is ready-to-merge. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5990998702 |
@FraserGreenroyd I have now provided a passing check on reference |
Closes #2780
Fixed a typo and fixed the compliance warnings from https://github.com/BHoM/BHoM_Engine/pull/2759/files