Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical_Engine: Fix typo and punctuations #2788

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

robinflyman
Copy link
Contributor

Closes #2780

Fixed a typo and fixed the compliance warnings from https://github.com/BHoM/BHoM_Engine/pull/2759/files

@robinflyman robinflyman added size:XS Measured in seconds type:compliance Non-conforming to code guidelines labels Apr 11, 2022
@robinflyman robinflyman self-assigned this Apr 11, 2022
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All typos fixed by inspection. No code changed. All seems compliant.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2022

@jamesramsden-bh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 12 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify the primary engine being updated by these changes in the PR title.

Some of the descriptions on some of those methods are absolutely ridiculous, but I know that's not down to you @robinflyman and is outside the scope of this PR but yikes can we do a session on revamping these at some point when there's some downtime @jamesramsden-bh @IsakNaslundBh

@robinflyman robinflyman changed the title BHoM_Engine: Fix typo and punctuations Physical_Engine: Fix typo and punctuations Apr 12, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance
  • dataset-compliance
  • ready-to-merge

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes have been made.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is ready-to-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5990998702

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5990998702

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2022

@FraserGreenroyd I have now provided a passing check on reference 5990998702 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 859621d into main Apr 13, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#2780-FixTyposAndPunctuation branch April 13, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS Measured in seconds type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_Engine: More instances of obejct to correct
3 participants