Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update CI Code to new CSProject format #2791

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #2790

Test files

N/A

As this is a change to CI only code, I am neutralising all checks to allow for a swift merge.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2022

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 6078427555

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot fix project file ref. 6078427555

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2022

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2022

@FraserGreenroyd I am now going to fix the CSProject compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2022

@FraserGreenroyd to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • project-compliance

There are 3 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, code-compliance, dataset-compliance, documentation-compliance, installer, ready-to-merge, versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • serialisation

There are 6 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check null-handling
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • null-handling
  • copyright-compliance

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FraserGreenroyd FraserGreenroyd merged commit 5972b55 into main Apr 19, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#2790-CIUpdates branch April 19, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.CI - use new CSProject format
3 participants