Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment_Engine: Hard coded default acceptOnEdges to true #2872

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Environment_Engine: Hard coded default acceptOnEdges to true #2872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Environment_Engine/Query/IsContaining.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public static bool IsContaining(this List<Panel> panels, Point point, bool accep
List<Point> ctrPoints = panels.SelectMany(x => x.Polyline().IControlPoints()).ToList();
BoundingBox boundingBox = BH.Engine.Geometry.Query.Bounds(ctrPoints);

if (!BH.Engine.Geometry.Query.IsContaining(boundingBox, point, acceptOnEdges, tolerance))
if (!BH.Engine.Geometry.Query.IsContaining(boundingBox, point, true, tolerance))
return false;

//We need to check one line that starts in the point and end outside the bounding box
Expand Down