Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: Added Query.FilterByNormal method #2877

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Jun 29, 2022

Issues addressed by this PR

Closes #2876

Added a method to filter a list of PlanarSurface objects by their surface normal, within a given tolerance.

Test files

Geometry_Engine-#2876-AddFilterByNormal.zip

Changelog

  • Query.FilterByNormal() Query method added in the Geometry_Engine for lists of PlanarSurface objects

Additional comments

@tg359 tg359 added severity:low Doesn't stop/slow current workflow size:S Measured in minutes type:feature New capability or enhancement labels Jun 29, 2022
@tg359 tg359 requested a review from pawelbaran as a code owner June 29, 2022 07:47
@tg359 tg359 self-assigned this Jun 29, 2022
@tg359
Copy link
Contributor Author

tg359 commented Jun 29, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 29, 2022

@tg359 to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 2 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Jul 5, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@tg359 to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 12 requests in the queue ahead of you.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tg359 for including my suggestions in the code. Now I am happy to approve it - it does what it is meant to do.

@pawelbaran
Copy link
Member

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 32 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran
Copy link
Member

@BHoMBot check versioning
@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@pawelbaran to confirm, the following checks are now queued:

  • versioning
  • copyright-compliance
  • dataset-compliance
  • ready-to-merge

There are 5 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 2a6e30a into main Jul 5, 2022
@pawelbaran pawelbaran deleted the Geometry_Engine-#2876-AddFilterByNormalMethod branch July 5, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:low Doesn't stop/slow current workflow size:S Measured in minutes type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: Add FilterByNormal method
2 participants